Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

N21-1512 Fix SchoolExternalTool metadata #2925

Merged
merged 2 commits into from
Nov 27, 2023
Merged

N21-1512 Fix SchoolExternalTool metadata #2925

merged 2 commits into from
Nov 27, 2023

Conversation

MarvinOehlerkingCap
Copy link
Contributor

@MarvinOehlerkingCap MarvinOehlerkingCap commented Nov 24, 2023 •
edited by arnegns
Loading

Short Description

Links to Ticket and related Pull-Requests

https://ticketsystem.dbildungscloud.de/browse/N21-1512
hpi-schul-cloud/schulcloud-server#4580

Changes

Data-security

Deployment

New Repos, NPM packages or vendor scripts

Screenshots of UI changes

Checklist before merging

  • QA: In addition to review, the code has been manually tested (if manual testing is possible)
  • PO: Any deviation from requirements was agreed with Product-Owner / ticket author / support-team
  • DEV: Every new component is implemented having accessibility in mind (e.g. aria-label, role property)

Notice: Please keep this Pull-Request as a Draft (or add WIP label), until it is ready to be reviewed

@MarvinOehlerkingCap MarvinOehlerkingCap changed the title fix mapping N21-1512 Fix SchoolExternalTool metadata Nov 24, 2023
@MarvinOehlerkingCap MarvinOehlerkingCap mentioned this pull request Nov 24, 2023
Merged
3 tasks
@sonarqubecloud SonarQubeCloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@MarvinOehlerkingCap MarvinOehlerkingCap merged commit a2cc466 into main Nov 27, 2023
43 of 44 checks passed
@MarvinOehlerkingCap MarvinOehlerkingCap deleted the N21-1512-fix-ctl-metadata branch November 27, 2023 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arnegns arnegns arnegns approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MarvinOehlerkingCap @arnegns